Code safety improvements #105
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paulofaria
previously approved these changes
Aug 17, 2022
There was a problem hiding this comment.
This looks great! We can merge this right away, but would also be nice to integrate swift-lint to enforce some of these rules. What do you think? I believe swift-lint also does formatting, but we can also integrate swift-format, if it works better. What is your experience?
paulofaria
approved these changes
Aug 17, 2022
|
Thanks Paulo! I think integrating swift-format is a great idea. I've only used Nick Lockwood's SwiftFormat, not Apple's swift-format, but from initial runs the Apple one looks more than adequate. I'll make a follow-up PR that integrates it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This MR removes a significant number of
fatalErrors, force-unwraps, force-trys, and force-casts. This is to improve code safety and be more in compliance with the SSWG Technical Best Practices.Some force operations remain, but they are mainly where throwing is not possible (top level literals), or in code mostly copied from a specific source. Examples of this include Encoder/Decoders that are based on Foundation's JSON coders, and Visitor based on the graphql-js reference implementation.